Fix read_flights() after changes to ANAC data access - #53
Merged
Conversation
Contributor
|
this looks promising! I'll merge it into the pr-test branch and try to fix the errors from there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
httr2to retrieve the ANAC data page.The new function
get_flights_files_available()returns adata.tablewith columnsdate,type, andurl, whereasget_flights_dates_available()is now a simple wrapper around it for backward compatibility ---I suggest removing it from the pipeline entirely.Furthermore, the result of
get_flights_files_available(minus the URL column) could be a useful output for the users, like a metadata/catalog table.Fixes #52